Wilco Dijkstra <wilco.dijks...@arm.com> writes: > Hi Richard, > >>> Yes, with a more general search loop we can get that case too - >>> it doesn't trigger much though. The code that checks for this is >>> now refactored into a new function. Given there are now many >>> more calls to aarch64_bitmask_imm, I added a streamlined internal >>> entry point that assumes the input is 64-bit. >> >> Sounds good, but could you put it before the mode version, >> to avoid the forward declaration? > > I can swap them around but the forward declaration is still required as > aarch64_check_bitmask is 5000 lines before aarch64_bitmask_imm.
OK, how about moving them both above aarch64_check_bitmask? Richard