On 8/2/22 18:27, Jan Hubicka wrote:
> If you disable dumping, you can also disable the collection of stats
> which is guarded by if (dump_file) as well. Otherwise the patch is OK.
Sure, good point!
I'm going to push the following.
Thanks,
Martin
From 7585e5ecb47761516b8f397002819f2c95b8c32e Mon Sep 17 00:00:00 2001
From: Martin Liska <mli...@suse.cz>
Date: Wed, 3 Aug 2022 10:53:22 +0200
Subject: [PATCH] profile: do not collect stats unless TDF_DETAILS
gcc/ChangeLog:
* profile.cc (compute_branch_probabilities): Do not collect
stats unless TDF_DETAILS.
---
gcc/profile.cc | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/gcc/profile.cc b/gcc/profile.cc
index 92de821b8bb..96121d60711 100644
--- a/gcc/profile.cc
+++ b/gcc/profile.cc
@@ -753,7 +753,8 @@ compute_branch_probabilities (unsigned cfg_checksum, unsigned lineno_checksum)
bb->count = profile_count::from_gcov_type (bb_gcov_count (bb));
else
bb->count = profile_count::guessed_zero ();
- if (dump_file && bb->index >= 0)
+
+ if (dump_file && (dump_flags & TDF_DETAILS) && bb->index >= 0)
{
double freq1 = cnt.to_sreal_scale (old_entry_cnt).to_double ();
double freq2 = bb->count.to_sreal_scale
@@ -776,8 +777,8 @@ compute_branch_probabilities (unsigned cfg_checksum, unsigned lineno_checksum)
nsum2 += stat.feedback;
fprintf (dump_file,
" Basic block %4i guessed freq: %12.3f"
- " cummulative:%6.2f%% "
- " feedback freq: %12.3f cummulative:%7.2f%%"
+ " cumulative:%6.2f%% "
+ " feedback freq: %12.3f cumulative:%7.2f%%"
" cnt: 10%" PRId64 "\n", stat.bb->index,
stat.guessed,
nsum1 * 100 / sum1,
--
2.37.1
