On Wed, Jul 13, 2022 at 04:14:11PM -0500, will schmidt wrote: > On Wed, 2022-07-13 at 14:39 -0500, Segher Boessenkool wrote: > > I'm not a fan of "internal" either, it doesn't say anything. At > > least > > put it at the very end of the names please? > I'm easily convinced. ;-) I wonder if I should just drop "_internal" > entirely and go with "vstrir_<mode>". Otherwise I'll rework to be > "vstrir_<mode>_internal".
The define_expand already uses that name. Some other patterns in altivec.md use *_direct, maybe that is nicer? > At a glance I see we do have some other existing define_insn entries > with _internal at the tail and a few others embedded in the middle. > I'll leave a note and perhaps review those after. :-) Thanks :-) Segher
