On Mon, Jul 04, 2022 at 05:25:42PM +0100, Jonathan Wakely wrote: > On Thu, 30 Jun 2022 at 16:15, Marek Polacek wrote: > > > > On Thu, Jun 30, 2022 at 04:11:42PM +0100, Jonathan Wakely via Gcc-patches > > wrote: > > > I recently changed <string> to no longer include an unnecessary header, > > > which meant it no longer includes <pthread.h>, which means it no longer > > > includes <time.h>. This resulted in some build failures: > > > https://issues.apache.org/jira/browse/LUCENE-10630 > > > https://github.com/openSUSE/libzypp/pull/405 > > > > > > And that revealed that we don't suggest the right header for those > > > functions. Fixed like so. > > > > > > Tested x86_64-linux. OK for trunk? > > > > Ok, thanks. > > OK for gcc-12 too? I already backported the include streamlining for > <string> that causes several packages to get errors for missing > <ctime>, so it makes sense to also backport these improved > diagnostics.
Since the patch isn't adding any new diagnostics that previously wasn't there, I think it's OK as well, thanks. Marek
