On Fri, 24 Jun 2022 at 12:08, Xi Ruoyao via Libstdc++ <[email protected]> wrote: > > On Fri, 2022-06-24 at 11:00 +0100, Jonathan Wakely wrote: > > On Fri, 24 Jun 2022 at 08:03, Xi Ruoyao via Libstdc++ > > <[email protected]> wrote: > > > > > > egrep has been deprecated in favor of grep -E for a long time, and > > > the > > > next grep release (3.8 or 4.0) will print a warning of egrep is > > > used. > > > Stop using egrep so we won't see the warning. > > > > > > libstdc++-v3/ChangeLog: > > > > > > * scripts/extract_symvers.in: Use grep -E instead of egrep. > > > * libstdc++-v3/scripts/run_doxygen: Likewise. > > > > This should be just scripts/run_doxygen here. You can use the git > > gcc-verify alias to check your changelog format. > > > > > > With that fixed it's OK for trunk and gcc-12 and gcc-11 branches, > > thanks! > > I'll need some rework as Rainer told me "grep -E" may not work on some > Solaris systems w/o GNU grep, and the code snippet in extract_symvers.in > is exactly for Solaris...
I checked that, and it's not :-) The egrep uses in extract_symvers.in are for everything *except* SunOS. For Solaris we use the scripts/extract_symvers.pl script instead. Your change might break generation of Doxygen API docs on Solaris, but maybe we can live with that.
