Re: [PATCH] middle-end/105711 - properly handle CONST_INT when expanding bitfields

[Richard Biener via Gcc-patches]

On Tue, 24 May 2022, Richard Sandiford wrote:

> Richard Biener <rguent...@suse.de> writes:
> > This is another place where we fail to pass down the mode of a
> > CONST_INT.
> >
> > Bootstrapped and tested on x86_64-unknown-linux-gnu, OK?
> >
> > Thanks,
> > Richard.
> >
> > 2022-05-24  Richard Biener  <rguent...@suse.de>
> >
> >     PR middle-end/105711
> >     * expmed.cc (extract_bit_field_as_subreg): Add op0_mode parameter
> >     and use it.
> >     (extract_bit_field_1): Pass down the mode of op0 to
> >     extract_bit_field_as_subreg.
> >
> >     * gcc.target/i386/pr105711.c: New testcase.
> 
> LGTM, but I guess the new parameter should be documented above
> extract_bit_field_as_subreg.

Ah, yes - fixed and pushed.

Thanks,
Richard.