On Mon, May 9, 2022 at 2:16 PM Martin Liška <mli...@suse.cz> wrote:
>
> On 5/9/22 13:58, Richard Biener wrote:
> > The patch would have been a lot smaller if you kept it Joined only?
>
> Yes, but the langspec rules append a space for some reason:
>
> $ ./xgcc -B. /tmp/1.h -ox.h.pch --save-temps --verbose
> ...
> ./cc1 -fpreprocessed x.h.pch-1.i ... --output-pch= x.h.pch
That's probably because we canonicalize Joined & Separate to
Separate and '{o*:--output-pch %*}' causes then '-o FOO' to be
matched with 'o*' and %* also outputs the matched space(?)
Anyway, I see how your approach avoids this and the --output-pch
switch doesn't seem documented (if one is concerned about
backwards compatibility).
So OK if there are no further comments within 48h.
Richard.
> Martin
