Hi!
Thank you for doing this testcase.
On Wed, Apr 27, 2022 at 06:29:07PM +0800, Kewen.Lin wrote:
> As discussed in PR105334, this patch is to add the test coverage for
> the two recent fixes r12-8091 and r12-8226 from Segher, aix is skipped
> since it takes soft-float and long-double-128 incompatible.
>
> I noticed the referred test case pack02.c skips if powerpc*-*-darwin*,
> but it's for do-run and I didn't have one machine to test that triple,
> so I didn't add that and hope it's unnecessary.
That is the best thing to do if you aren't sure, the Darwin people are
in a much better position to decide this themselves. Cc:ed Iain.
> Tested on powerpc64-linux-gnu P8, powerpc64le-linux-gnu P9/P10 and
> powerpc-ibm-aix7.2.0.0.
>
> Is ok for trunk?
Okay for trunk, thanks! Please see if David has some more input?
> --- /dev/null
> +++ b/gcc/testsuite/gcc.target/powerpc/pr105334.c
> @@ -0,0 +1,31 @@
> +/* Skip this on aix, since it takes soft-float and long-double-128
> + incompatible and warns it. */
> +/* { dg-skip-if "aix long-double-128 soft-float" { powerpc*-*-aix* } } */
> +/* { dg-options "-mlong-double-128 -msoft-float" } */
Maybe you just want to add "-w" and not skip on AIX, if the test
generates the correct code anyway? Either way works for me though.
Segher
