On Wed, 30 Oct 2013 10:41:33 +0100
Bernhard Reutner-Fischer <[email protected]> wrote:
> > Hi!
> >
> > I've noticed that this testcase doesn't clean up after itself.
> > Fixed thusly, committed as obvious to trunk.
>
> This was nagging me last weekend.. ;)
> What about automating this?
>
> Manual part is attached.
> The "Adjust all callers" below is too big to send to the list:
> git grep -l -E "(cleanup-.*-dump|cleanup-saved-temps)" | \
> egrep -v "(ChangeLog|/lib/)" | sed -e "s|[^/]*$||" | sort | uniq | \
> while read d;
> do
> find $d -type f \
> -exec sed -i -e "/cleanup-[^-]*[-]*dump/d;/cleanup-saved-temps/d" {} +
> done
>
>
> Full regstrap on x86_64-unknown-linux-gnu with no regressions with
> trunk@204119 for
> configure \
> --enable-bootstrap \
> --with-system-zlib \
> --without-included-gettext \
> --disable-werror \
> --enable-link-mutex \
> --enable-nls \
> --enable-plugin \
> --enable-__cxa_atexit \
> --enable-debug \
> --enable-checking=yes,rtl \
> --enable-gather-detailed-mem-stats \
> --enable-multilib \
> --enable-multiarch \
> --with-linker-hash-style=both \
> --with-as=$BINU/as \
> --with-ld=$BINU/ld.gold \
> --enable-languages=c,c++,fortran,lto,go,objc,obj-c++ \
> && make -k check -j4
>
> Ok for trunk?
> Comments?
>
> Given the "Fix comment delimiter" hunks in the manual patch, i'd suggest
> to add -Wcomment as default flags where possible to catch these early on
> in the future.
I should not dare to ping this proposal just yet again, now, without due
patience. But, maybe, we want to automatically add -Wcomment to the
testsuite unless a testcase mentions "comment" in their flags to catch
such malformed comments with dejagnu directives, next stage 1?
The handling should probably be about like what we did with the
-fno-ident that was added to the testsuite as to not confuse
scan-assembler test due to local branch names which was applied in
eb6ffc66825a8d36cf89881517624ff2df510aa9 ( r9-2792 )
https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=eb6ffc66825a8d36cf89881517624ff2df510aa9
iff maybe this can aid as a guide for someone to fix this for good.
TIA,
>
> gcc/testsuite/ChangeLog
>
> 2013-10-12 Bernhard Reutner-Fischer <[email protected]>
>
> * lib/gcc-dg.exp (cleanup-ipa-dump, cleanup-rtl-dump,
> cleanup-tree-dump, cleanup-dump): Remove. Adjust all callers.
> (schedule-cleanups): New proc.
> (gcc-dg-test-1): Call it.
> * lib/profopt.exp (profopt-execute): Likewise.
> * g++.dg/cdce3.C: Adjust expected line numbers.
> * gcc.dg/cdce1.c: Likewise.
> * gcc.dg/cdce2.c: Likewise.
> * gcc.dg/strlenopt-22.c: Fix comment delimiter.
> * gcc.dg/strlenopt-24.c: Likewise.
> * gcc.dg/tree-ssa/vrp26.c: Likewise.
> * gcc.dg/tree-ssa/vrp28.c: Likewise.
> * obj-c++.dg/encode-2.mm: Likewise.
>
> libgomp/ChangeLog
>
> 2013-10-12 Bernhard Reutner-Fischer <[email protected]>
>
> * testsuite/libgomp.graphite/bounds.c: Adjust for
> cleanup-tree-dump removal.
> * testsuite/libgomp.graphite/force-parallel-1.c: Likewise.
> * testsuite/libgomp.graphite/force-parallel-2.c: Likewise.
> * testsuite/libgomp.graphite/force-parallel-3.c: Likewise.
> * testsuite/libgomp.graphite/force-parallel-4.c: Likewise.
> * testsuite/libgomp.graphite/force-parallel-5.c: Likewise.
> * testsuite/libgomp.graphite/force-parallel-6.c: Likewise.
> * testsuite/libgomp.graphite/force-parallel-7.c: Likewise.
> * testsuite/libgomp.graphite/force-parallel-8.c: Likewise.
> * testsuite/libgomp.graphite/force-parallel-9.c: Likewise.
> * testsuite/libgomp.graphite/pr41118.c: Likewise.
>
>
> gcc/ChangeLog
>
> 2013-10-12 Bernhard Reutner-Fischer <[email protected]>
>
> * config/arm/neon-testgen.ml (emit_epilogue): Remove manual call
> to cleanup-saved-temps.
>
> gcc/doc/ChangeLog
>
> 2013-10-12 Bernhard Reutner-Fischer <[email protected]>
>
> * doc/sourcebuild.texi (Clean up generated test files): Expand
> introduction.
> (cleanup-ipa-dump, cleanup-rtl-dump, cleanup-tree-dump,
> cleanup-saved-temps): Remove.
