On 08/04/2022 15:48, Przemyslaw Wirkus via Gcc-patches wrote:
Hi,

This patch is removing unnecessary armv9-a multilib variant which was
introduced in commit 32ba7860ccaddd5219e6dae94a3d0653e124c9dd (add
armv9-a architecture to -march). Now armv9-a(+simd) multilibs point to
already existing armv8-a(+simd) ones as there are no changes between
the two.
Users will no longer require Binutils supporting `armv9-a` to build toolchain.

See multilib print below as well:

$ for v in {7..9}
   do
     ./arm-gcc -march=armv$v-a test.c --specs=rdimon.specs 
-print-multi-directory
   done
thumb/v7-a/nofp
thumb/v8-a/nofp
thumb/v8-a/nofp

Regtested on arm-none-eabi cross and no issues.
OK to install?

PS: If approved can I ask for someone to commit in my name pretty please?

gcc/ChangeLog:

        PR target/PR104144
        * config/arm/t-aprofile: Remove armv9-a multilib.
        * config/arm/t-multilib: Remove armv9-a multilib.

gcc/testsuite/ChangeLog:

        PR target/PR104144
        * gcc.target/arm/multilib.exp: Updated tests.


I've tweaked the commit message as follows and applied this:

Remove the armv9-a specific multilib variants.  Instead, arrange to
use either the armv8-a multilibs or the armv7-a versions, depeding on
the configuration.  This eliminates the need to have a version of gas
that understands --march=armv9-a when building GCC.  Very little, if
anything in the standard libraries directly uses Armv9-a features
anyway.

Also remove the +crc variant rules for Armv9-a.  CRC is an implicit
part of Armv9-a, so doesn't have a explicit feature to handle it.

gcc/ChangeLog:

        PR target/104144
        * config/arm/t-aprofile (MULTI_ARCH_OPTS_A): Remove Armv9-a options.
        (MULTI_ARCH_DIRS_A): Remove Armv9-a diretories.
        (MULTILIB_REQUIRED): Don't require Armv9-a libraries.
        (MULTILIB_MATCHES): Treat Armv9-a as equivalent to Armv8-a.
        (MULTILIB_REUSE): Remove remap rules for Armv9-a.
        * config/arm/t-multilib (v9_a_nosimd_variants): Delete.
        (MULTILIB_MATCHES): Remove mappings for v9_a_nosimd_variants.

gcc/testsuite/ChangeLog:

        PR target/104144

In future, please do not send patches in the body if your mailer is using 'quoted-printable', it makes extracting the patch to apply extremely tricky.

R.

Reply via email to