On Tue, 22 Mar 2022, Tobias Burnus wrote: > Hi Jakub, hi Richi, > > On 22.03.22 15:27, Jakub Jelinek wrote: > > On Tue, Mar 22, 2022 at 01:56:27PM +0100, Tobias Burnus wrote: > >> name = lto_get_decl_name_mapping (file_data, name); > >> [...] > >> + name = lto_get_decl_name_mapping (file_data, name); > >> > >> This looks weird. IMHO we should make sure that the hash table contains > >> always the final names, so that we don't need to call it twice or even more > >> times. > > I concur – and I have changed it (see attached patch). And it still passes the > testsuite. > > (It came about because I started reverse – and in > 'cgraph_node::get_untransformed_body', > it happened that the second map was already present + I added the second > lookup. > Extending the tests, I found that I also had to change > privatize_symbol_name_1. Thus, > I added the additional mapping there. However, it seems to be enough to only > change > privatize_symbol_name_1 to track the double renaming in one step. > That's what the updated patch does (+ unchanged changes for linkptr + the > hash-key part). > > > The lto.cc changes LGTM. The rest I'm unfortunately not too familiar with, > > Richi or Honza, could you please have a look? > > (^ to be done by Honza or Richi) > > > This is the same thing again as above, right? > > Yes. (Now also removed.) > > Thanks for the first review and for nagging about the rename tracking.
OK. Thanks, Richard.
