On Mon, Mar 14, 2022 at 7:03 AM Jakub Jelinek <ja...@redhat.com> wrote:
>
> On Mon, Mar 14, 2022 at 06:49:01AM -0700, H.J. Lu via Gcc-patches wrote:
> > gcc/
> >
> >       PR target/104890
> >       * config/i386/i386.cc (ix86_can_inline_p): Ignore
> >       OPTION_MASK_ISA_64BIT for -m32.
> >
> > gcc/testsuite/
> >
> >       PR target/104890
> >       * gcc.target/i386/pr104890.c: New test.
> > ---
> >  gcc/config/i386/i386.cc                  |  4 ++++
> >  gcc/testsuite/gcc.target/i386/pr104890.c | 11 +++++++++++
> >  2 files changed, 15 insertions(+)
> >  create mode 100644 gcc/testsuite/gcc.target/i386/pr104890.c
> >
> > diff --git a/gcc/config/i386/i386.cc b/gcc/config/i386/i386.cc
> > index 23bedea92bd..f2bb4765e5b 100644
> > --- a/gcc/config/i386/i386.cc
> > +++ b/gcc/config/i386/i386.cc
> > @@ -587,6 +587,10 @@ ix86_can_inline_p (tree caller, tree callee)
> >    if (TARGET_GENERAL_REGS_ONLY_P (callee_opts->x_ix86_target_flags))
> >      always_inline_safe_mask |= MASK_80387;
> >
> > +  /* Ignore OPTION_MASK_ISA_64BIT for -m32.  */
> > +  if (!TARGET_64BIT)
> > +    always_inline_safe_mask |= OPTION_MASK_ISA_64BIT;
>
> This looks wrong.  (1 << 1) in alwyas_inline_safe_mask and
> *->x_target_flags is MASK_80387, not OPTION_MASK_ISA_64BIT.
>
>         Jakub

Here is the v2 patch:

https://gcc.gnu.org/pipermail/gcc-patches/2022-March/591716.html

-- 
H.J.

Reply via email to