On Fri, Mar 11, 2022 at 02:41:05PM -0600, Segher Boessenkool wrote: > On Fri, Mar 11, 2022 at 01:07:29AM -0500, Michael Meissner wrote: > > Fix DImode to TImode sign extend issue, PR target/104898 > > > When I wrote the extendditi2 pattern, I forgot that mtvsrdd had that > > behavior so I used a 'r' constraint instead of 'b'. In the rare case > > where the value is in GPR register 0, this split will fail. > > Note that the machine instructions it would generate would work fine: > mtvsrdd X,0,Y can be used as a "mtvsrld" always. In fact, generating > such code would be better than mtvsrdd always here. > > Do you want to try that? If not, this is okay for trunk. Thanks!
Right now, it will need support (since we don't have a zero_extendditi2 pattern right now). I am working on optimizations to do this, but right now it is simplest just to use "b". -- Michael Meissner, IBM PO Box 98, Ayer, Massachusetts, USA, 01432 email: meiss...@linux.ibm.com
