Hi Iain, On Thu, Feb 24, 2022 at 04:02:30PM +0000, Iain Sandoe wrote: > > On 22 Feb 2022, at 14:44, Vladimir Makarov <vmaka...@redhat.com> wrote: > > On 2022-02-20 12:34, Iain Sandoe wrote: > >> > >> ^^^ this is mostly for my education - the stuff below is a potential > >> solution to leaving lra-constraints unchanged and fixing the Darwin bug…. > >> > > I'd be really glad if you do manage to fix this w/o changing LRA. Richard > > has a legitimate point that my proposed change in LRA prohibiting > > `...;reg=low_sum; ...mem[reg]` might force LRA to generate less optimized > > code or even might make LRA to generate unrecognized insns `reg = orginal > > addr` for some ports requiring further fixes in machine-dependent code of > > the ports. > > I think this is within my remit to push without further review - however I’d > very much welcome any comment you folks have: I’d like to push this before my > weekly Darwin test run - which is usually started just after the daily bump > on Saturday morning. > > The other RS6000 changes remain, as Vlad pointed out we were not being picky > enough there - despite getting away with it for longer than I’ve been on the > project ;) > > I tested that the patch fixes the problem on 11.2 (for the testcases > provided, the bug is latent on master) and causes no regressions on > powerpc-darwin9 (master).
Nothing in the patch does anything if TARGET_MACHO isn't true, so it is all fine with me. It does look good to me fwiw (the empty constraints are a bit nasty, but they aren't new). Okay for trunk wrt rs6000. Thanks! Segher
