Hi! On Tue, Feb 15, 2022 at 01:03:09PM -0600, Peter Bergner wrote: > The HTM tbegin. instruction can fail intermittently due to many reasons.
Just a few really. But, if the transaction fails it will appear as if the tbegin. had an error as well, is that what you are seeing? > This can lead to the htm-1.c testsuite test case FAILing from time to time. > The solution is to allow retrying the instruction a few times before aborting. That is the way any HTM code should be written in the first place (except for rollback-only transactions, but let's not go there -- besides, it is normal for those to fail as well, and there needs to be a fallback there as well :-) ) The patch is fine. Okay for trunk and backports (after soak time ofc). Thanks! Segher > gcc/testsuite/ > * gcc.target/powerpc/htm-1.c: Retry intermittent failing tbegins.