On Fri, Feb 4, 2022 at 2:08 PM Rainer Orth <r...@cebitec.uni-bielefeld.de> wrote: > > Hi Martin, > > > It seems to me that fixincludes is hardy unused feature for nowadays header > > files and so I'm suggesting a developer option that can skip the fixing. > > please remember that there's a world beyond current-day Linux. > > > How is the feature used on other targets? > > There are still quite a number of fixes on e.g. Solaris or macOS. And > people are still building gcc on older OS versions for one reason or > another... > > > diff --git a/gcc/configure.ac b/gcc/configure.ac > > index 1171c946e6e..6015e403aa9 100644 > > --- a/gcc/configure.ac > > +++ b/gcc/configure.ac > > @@ -842,6 +842,12 @@ gather_stats=`if test > > $enable_gather_detailed_mem_stats != no; then echo 1; else > > AC_DEFINE_UNQUOTED(GATHER_STATISTICS, $gather_stats, > > [Define to enable detailed memory allocation stats gathering.]) > > > > +AC_ARG_ENABLE(disable-fix-includes, > > +[AS_HELP_STRING([--disable-fix-includes], > > The beast is called fixincludes, no '-' or '_'. > > > + [skip fixing of includes])], [], > > Better say 'running fixincludes' for example rather than being > vague/obtuse. > > The new options requires documenting in install.texi. > > That said, I'm not sure this is really worth yet adding another option. > And how are developers supposed to know if they can safely use it or > not. > > Besides, have you actually run a regtest with that option? I'm asking > because even on Ubuntu 20.04 fixincludes drops in it's own <limits.h>. > You need to check that dropping that is actually safe.
limits.h and syslimits.h are the only include-fixed we "ship" in our packages. Not sure if they are really required though. Richard. > > Rainer > > -- > ----------------------------------------------------------------------------- > Rainer Orth, Center for Biotechnology, Bielefeld University
