On 2/3/22 16:19, Jeff Law wrote:
On 2/3/2022 7:56 AM, Martin Liška wrote:
In my case:
$ rm ./stmp-fixinc ; time make -j16
takes 17 seconds, where I can reduce it easily with the suggested
change. Then I get to 11.2 seconds.
The scripts searches ~2500 folders in my case with total 20K header
files.
Ready to be installed?
Thanks,
Martin
fixincludes/ChangeLog:
* fixinc.in: Use mkdir -p rather that a loop.
Don't we run the risk of overflowing ARG_MAX with this style invocation?
jeff
You are correct, fixed in the attached V2.
What do you think now?
Thanks,
Martin
From 0ba77db8a29ad1d98937d1deedbe1ad86638fc23 Mon Sep 17 00:00:00 2001
From: Martin Liska <mli...@suse.cz>
Date: Thu, 3 Feb 2022 15:49:43 +0100
Subject: [PATCH] Speed up fixincludes.
In my case:
$ rm ./stmp-fixinc ; time make -j16
takes 17 seconds, where I can reduce it easily with the suggested
change. Then I get to 11.2 seconds.
The scripts searches ~2500 folders in my case with total 20K header
files.
fixincludes/ChangeLog:
* fixinc.in: Use mkdir -p rather that a loop.
---
fixincludes/fixinc.in | 23 +++++++++++++++++------
1 file changed, 17 insertions(+), 6 deletions(-)
diff --git a/fixincludes/fixinc.in b/fixincludes/fixinc.in
index de5a37f6acc..92f3dfc39a9 100755
--- a/fixincludes/fixinc.in
+++ b/fixincludes/fixinc.in
@@ -258,12 +258,23 @@ then echo "All directories (including links to directories):"
echo $all_dirs
fi
-for file in $all_dirs; do
- rm -rf $LIB/$file
- if [ ! -d $LIB/$file ]
- then mkdir $LIB/$file
- fi
-done
+ARG_MAX=`getconf ARG_MAX 2>/dev/null`
+LENGTH=`expr length "$all_dirs" + 10`
+
+if test -n "$ARG_MAX" && test $LENGTH -lt $ARG_MAX
+then
+ cd $LIB
+ mkdir -p $all_dirs
+ cd ..
+else
+ for file in $all_dirs; do
+ rm -rf $LIB/$file
+ if [ ! -d $LIB/$file ]
+ then mkdir $LIB/$file
+ fi
+ done
+fi
+
mkdir $LIB/root
# # # # # # # # # # # # # # # # # # # # #
--
2.35.1
