On Thu, 2022-02-03 at 11:23 +0000, Jonathan Wakely wrote: > On 03/02/22 12:08 +0100, David Seifert wrote: > > * `-Werror` can cause issues when a more recent version of GCC > > compiles > > an older version: > > - https://bugs.gentoo.org/229059 > > - https://bugs.gentoo.org/475350 > > - https://bugs.gentoo.org/667104 > > Honouring --disable-werror everywhere seems reasonable to me (but I > can't approve it). > > It will need a ChangeLog in the Git commit message, of the form: > > libatomic/ChangeLog: > > * libatomic/configure.ac: Support --disable-werror. > * libatomic/configure: Regenerate. > > libbacktrace/ChangeLog: > > * libbacktrace/configure.ac: Support --disable-werror. > * libbacktrace/configure: Regenerate. > > libgo/ChangeLog: > > * libgo/configure.ac: Support --disable-werror. > * libgo/configure: Regenerate. > > libgomp/ChangeLog: > > * libgomp/configure.ac: Support --disable-werror. > * libgomp/configure: Regenerate. > > libitm/ChangeLog: > > * libitm/configure.ac: Support --disable-werror. > * libitm/configure: Regenerate. > > libsanitizer/ChangeLog: > > * libsanitizer/configure.ac: Support --disable-werror. > * libsanitizer/libbacktrace/Makefile.am (WARN_FLAGS): Remove. > > > And if you don't have an FSF assignment on file for GCC, you can > contribute it under the terms of https://gcc.gnu.org/dco.html (and if > you want to do that, please add the Signed-off-by: tag to indicate > you've understood those terms and agreed to them). > > > Is the hunk below removing the warning flags so that they use the ones > from the parent directory?
correct > > diff --git a/libsanitizer/libbacktrace/Makefile.am > > b/libsanitizer/libbacktrace/Makefile.am > > index 16accd468df..0cf8d2104c0 100644 > > --- a/libsanitizer/libbacktrace/Makefile.am > > +++ b/libsanitizer/libbacktrace/Makefile.am > > @@ -34,8 +34,6 @@ ACLOCAL_AMFLAGS = -I ../.. -I ../../config > > AM_CPPFLAGS = -I $(top_srcdir)/../include -I $(top_srcdir)/../libgcc > > \ > > -I ../../libgcc -I .. -I $(top_srcdir) -I > > $(top_srcdir)/../libbacktrace > > > > -WARN_FLAGS = -W -Wall -Wwrite-strings -Wmissing-format-attribute \ > > - -Wcast-qual -Werror > > C_WARN_FLAGS = $(WARN_FLAGS) -Wstrict-prototypes -Wmissing- > > prototypes -Wold-style-definition > > CXX_WARN_FLAGS = $(WARN_FLAGS) -Wno-unused-parameter > > AM_CFLAGS = $(C_WARN_FLAGS) >
