Le 23/01/2022 à 11:05, FX a écrit :
Hi Mikael,
I spotted two unexpected things (to me at least) related to x86 extended type:
- You check for endianness, so the format is not x86-specific?
- Is it expected that the padding bits are in the middle of the data in the
big-endian case?
IEEE specifies that extended precision types can be present, possibly with any
endianness, at least in theory. There are other CPUs with extended precision
types than Intel, although we probably don’t support them currently in
gfortran: Motorola 68881 has a IEEE-compatible 80-bit format and is big endian.
I kept the code generic, but if you think it’s a problem I can remove that part
and make it error out.
No, it’s not a problem, I just was surprised to see endianness checks as
I thought it was x86-only.
I followed the logic used in glibc to deal with bit layout and endianness, so
it should be safe as currently proposed.
Then it’s OK to commit for me, but you will need approval from release
managers at this stage.
Thanks.
