On Sun, 16 Jan 2022 at 18:13, Patrick Palka via Libstdc++ < libstd...@gcc.gnu.org> wrote:
> We're going to use the fast_float library in our (compiled-in) > floating-point std::from_chars implementation for faster and more > portable parsing of binary32/64 decimal strings. > > The single file fast_float.h is an amalgamation of the entire library, > which can be (re)generated with the command > > python3 ./script/amalgamate.py --license=MIT \ > > $GCC_SRC/libstdc++-v3/c++17/fast_float/fast_float.h > Please mention that the script is in the fast_float repo (so people don't look for it in our repo). Please mention in the commit log that the code has a GPL-compatible licence. > > [1]: https://github.com/fastfloat/fast_float > > libstdc++-v3/ChangeLog: > > * src/c++17/fast_float/LOCAL_PATCHES: New file. > * src/c++17/fast_float/MERGE: New file. > * src/c++17/fast_float/README.fd: New file, copied from the > fast_float library sources. > * src/c++17/fast_float/fast_float.h: New file, an amalgamation > of the fast_float library. > > Signed-off-by: Patrick Palka <ppa...@redhat.com> > This project is great. The licence is compatible, and the licence text and copyright notices are preserved in the code being imported. The entire license text is present in the header, so there is no need for a separate licence file. The symbols that will be added to libstdc++ are not uglified, but the header is included inside an unnamed namespace, so we will not define any non-reserved symbols in libstdc++.a (and they aren't exported from libstdc++.so anyway). OK for trunk.
