Robin Dapp <rd...@linux.ibm.com> writes:
> Hi Richard,
>
> I incorporated all your remarks (sorry for the hunk from a different
> branch) except for this one:
>
>> Think it would be better to make it:
>>
>> if (use_bias_adjusted_len)
>> {
>> gcc_assert (i == 0);
>>
>> But do we need to do this? Code should only care about the final value,
>> so I didn't think we would need to keep the intermediate unbiased length
>> alongside the biased one. (Or maybe we do. My memory is a bit rusty,
>> sorry.)
>
> I'd agree that we generally don't need to keep the unbiased length.
> However "loop_len" being a phi node, I wasn't sure how or where to
> properly apply the bias (except via creating a new variable like I did).
> Would be thankful about a pointer here.
Ah, I see. Yeah, I guess the loop manip stuff does still need
access to the unbiased value, so I agree we should keep both.
Thanks,
Richard
