> > I plan to reduce the value during before christmas after bit more testing > > since > > it seems to be overall win even if we trade fatigue2 performance, but I > > would > > like to get more testing on larger C++ APPs first. > > Will this hurt -Os -finline-limit=0 ?
Why do you use -finline-limit=0 with -Os? The patch does affect inlining even with -Os. On my benchmarks inlining very large functions is hit or miss code size wise (in pure theory inlining those should be always a win but it is not - even ignoring build times we stress regalloc and more likely hit various --param thresholds) I guess we could experiment with code size impact and possibly make -Os defaults to differ from -O defaults like we do for some other params. Honza > thanks,