On 3/03/2012, at 1:55 PM, Maxim Kuvyrkov wrote: > On 30/09/2011, at 1:11 AM, Bernd Schmidt wrote: > ... >> >> The following patch rewrites essentially all the cond_exec support in >> ifcvt; reviewing is probably easier if it's thought of as new code. > > Kudos for improving if-conversion! > > I reviewed this patch to the extent I know ifcvt.c, which is below your level > of understanding.
I realized this sentence can be read in two different ways. Obviously I meant that you have a superior understanding of if-conversion than I :-). > The new implementation looks good to me, and my review mostly focuses on > making the code more understandable to someone without the in-depth knowledge > of optimization. -- Maxim Kuvyrkov CodeSourcery / Mentor Graphics