On Mon, Nov 8, 2021 at 12:01 PM Jan Hubicka via Gcc-patches <gcc-patches@gcc.gnu.org> wrote: > > > On 11/5/21 18:30, Jan Hubicka wrote: > > > every gcc source looks like bit of overkill given that is can be open > > > coded in 3 statements? > > > > Why? It's a static inline function with few statements. I don't want to > > copy&paste > > the same code at every location. I bet there must quite some open-coded > > implementations > > of endswith in the GCC source code. > > I guess it is a matter of taste, but to me system.h should not be > universal include bringing a lot of unrelated things because in long > term it is how precompiled headers came to be. In theory such random > generally useful things probably would belong to libiberty, but that > also seems but of overkill to me. > > Anyway I guess we need someone with approval right to system.h to OK > that. I see there is already startswith so having endwith is probably > not too bad.
OK. Richard. > Honza > > > > Martin