On Fri, Oct 29, 2021 at 06:20:15PM +0200, Tobias Burnus wrote:
> On 29.10.21 13:06, Jakub Jelinek wrote:
> > On Thu, Oct 28, 2021 at 05:51:59PM +0200, Tobias Burnus wrote:
> > > libcpp/ChangeLog:
> > >
> > > PR c++/102409
> > > * directives.c (destringize_and_run): Add PRAGMA_OP to the
> > > CPP_PRAGMA token's flags to mark is as coming from _Pragma.
> > > * include/cpplib.h (PRAGMA_OP): #define, to be used with token flags.
> > > * macro.c (collect_args): Only handle CPP_PRAGMA special if PRAGMA_OP
> > > is set.
> > >
> > The patch itself looks reasonable to me, but it should come up with
> > testsuite coverage. And the testsuite coverage should include both normal
> > testcases that do use integrated preprocessor, and the same with
> > -save-temps to make sure that even when preprocessing separately it works
> > too.
>
> Yes, I realized myself that I missed to include a testcase – thanks for
> the -save-temps suggestion!
>
> Updated patch enclosed.
Ok, thanks.
For backports, I'd wait a few weeks.
Jakub
