On Tue, Oct 26, 2021 at 06:51:09PM +0100, Maciej W. Rozycki wrote:
> On Tue, 26 Oct 2021, Martin Liška wrote:
>
> > Please remove your name from Write After Approval:
> >
> > $ make check -k RUNTESTFLAGS="maintainers.exp"
> > ...
> > Running /home/marxin/Programming/gcc/gcc/testsuite/gcc.src/maintainers.exp
> > ...
> > Redundant in write approval: Maciej W. Rozycki
> > FAIL: maintainers-verify.sh
>
> Hmm, that seems like useless policy to me; the "Write After Approval"
> section used to be an exhaustive, alphabetically sorted list of people
> with commit rights, and it still is with our sister projects binutils and
> GDB. By removing entries for people listed elsewhere (which may be across
> several places anyway) you require one to look for information scattered
> around the file. And contributors to remember adding themselves back as
> they step down from maintainer posts.
>
> Besides, my e-mail addresses listed are different in the two sections,
> and that's been deliberate. Also what about people carrying identical
> full names? I insist on using my middle initial for a reason.
>
> It seems like there's been hardly any discussion about this matter around
> the time this stuff was added with commit bddcac9d1c32 ("[contrib] Add
> contrib/maintainers-verify.sh"). What was the actual motivation behind
> that change?
That was only addition of a script and testcase to verify what has been done
in MAINTAINERS since forever.
Just look at all the commits to remove redundant entries from Write After
Approval, e.g.
https://gcc.gnu.org/legacy-ml/gcc-patches/2003-05/msg00366.html
All maintainers or reviewers (global or specific) have write after approval
rights for areas they don't maintain.
Jakub
