On 9/30/2021 12:47 AM, Thomas Schwinge wrote:
Hi!
On 2021-09-17T13:16:14+0200, I wrote:
On 2021-09-10T09:48:56+0200, I wrote:
Ping. My patches again attached, for easy reference.
Ping once again.
Jeff had ACKed "Don't record string concatenation data for
'RESERVED_LOCATION_P'" (thanks!), but "Generalize 'gcc/input.h:struct
location_hash'" is still awaiting review:
On 2021-09-03T18:33:37+0200, I wrote:
On 2021-09-02T21:09:54+0200, I wrote:
On 2021-09-02T15:59:14+0200, I wrote:
On 2016-08-05T14:16:58-0400, David Malcolm <dmalc...@redhat.com> wrote:
Committed to trunk as r239175; I'm attaching the final version of the
patch for reference.
David, you've added here 'gcc/input.h:struct location_hash' (see quoted
below), which will be useful elsewhere, so:
--- a/gcc/input.h
+++ b/gcc/input.h
+struct location_hash : int_hash <location_t, UNKNOWN_LOCATION> { };
+
+class GTY(()) string_concat_db
+{
+[...]
+ hash_map <location_hash, string_concat *> *m_table;
+};
OK to push the attached
"Generalize 'gcc/input.h:struct location_hash'"?
Attached again, for easy reference.
Grüße
Thomas
-----------------
Siemens Electronic Design Automation GmbH; Anschrift: Arnulfstraße 201, 80634
München; Gesellschaft mit beschränkter Haftung; Geschäftsführer: Thomas
Heurung, Frank Thürauf; Sitz der Gesellschaft: München; Registergericht
München, HRB 106955
0002-Generalize-gcc-input.h-struct-location_hash.patch
From 349a3172f64db93ee98ea39b36489b702b6596ab Mon Sep 17 00:00:00 2001
From: Thomas Schwinge <tho...@codesourcery.com>
Date: Tue, 31 Aug 2021 23:30:25 +0200
Subject: [PATCH 2/2] Generalize 'gcc/input.h:struct location_hash'
This is currently only used here ('gcc/input.h:class string_concat_db'), but is
actually generally useful, so advertize it as such.
Per the rationale given, we may use 'BUILTINS_LOCATION' as spare value for
'Deleted', in addition to the existing use of 'UNKNOWN_LOCATION' as spare value
for 'Empty'.
gcc/
* input.h (location_hash): Use 'BUILTINS_LOCATION' as spare value
for 'Deleted'. Turn into a '#define'.
OK
jeff
