On Wed, Sep 08, 2021 at 03:25:24PM +0000, Joseph Myers wrote:
> When testing for Nios II (gcc-testresults shows this for MIPS as
> well), failures of gcc.dg/array-quals-1.c appear where a symbol was
> found in .sdata rather than one of the expected sections.
>
> FAIL: gcc.dg/array-quals-1.c scan-assembler-symbol-section symbol ^_?a$
> (found a) has section ^\\.(const|rodata|srodata)|\\[RO\\] (found .sdata)
> FAIL: gcc.dg/array-quals-1.c scan-assembler-symbol-section symbol ^_?b$
> (found b) has section ^\\.(const|rodata|srodata)|\\[RO\\] (found .sdata)
> FAIL: gcc.dg/array-quals-1.c scan-assembler-symbol-section symbol ^_?c$
> (found c) has section ^\\.(const|rodata|srodata)|\\[RO\\] (found .sdata)
> FAIL: gcc.dg/array-quals-1.c scan-assembler-symbol-section symbol ^_?d$
> (found d) has section ^\\.(const|rodata|srodata)|\\[RO\\] (found .sdata)
>
> Jakub's commit 0b34dbc0a24864b1674bff7a92fa3cf0f1cbcea1 allowed .sdata
> for many variables in that test where use of .sdata caused a failure
> on powerpc-linux. I'm presuming the choice of which variables had
> .sdata allowed was based only on the code generated for powerpc-linux,
> not on any reason it would be wrong to allow it for the other
Yeah.
> variables; thus, this patch adjusts the test to allow .sdata for some
> more variables where that is needed on Nios II (and in one case where
> it's not needed on Nios II, but the test results on gcc-testresults
> suggest that it is needed on MIPS).
>
> Tested with no regressions with cross to nios2-elf. OK to commit?
>
> * gcc.dg/array-quals-1.c: Allow .sdata section in more cases.
LGTM.
Jakub
