Sorry for the slow reply. Alistair Lee via Gcc-patches <gcc-patches@gcc.gnu.org> writes: > Hi all, this patch changed some RTL nodes to appropriate macros in Aarch64.c > backend using a script. Would this be okay for trunk? > > > Also, this is my first contribution, and I do not yet have commit > rights, so if everything is okay could someone commit this for me? > > Thank you and I would appreciate any feedback/advice! > > > gcc/ChangeLog: > > > 2021-07-21 Alistair_Lee alistair....@arm.com > > > * rtl.h (CONST_VECTOR_P): New macro. > (CONST_STRING_P): New macro.
Since the patch doesn't add any uses of CONST_STRING_P, I think it would be better not to add it at this stage. (CONST_STRING is rarely used outside generators.) Looks good otherwise, thanks. I've pushed it to trunk without the CONST_STRING_P part. Richard > > * config/aarch64/aarch64.c (aarch64_get_sve_pred_bits): Use RTL > code testing macros. > (aarch64_ptrue_all_mode): Likewise. > (aarch64_expand_mov_immediate): Likewise. > (aarch64_const_vec_all_in_range_p): Likewise. > (aarch64_rtx_costs): Likewise. > (aarch64_legitimate_constant_p): Likewise. > (aarch64_simd_valid_immediate): Likewise. > (aarch64_simd_make_constant): Likewise. > (aarch64_convert_mult_to_shift): Likewise. > (aarch64_expand_sve_vec_perm): Likewise. > (aarch64_vec_fpconst_pow_of_2): Likewise.
