Jonathan Wright <jonathan.wri...@arm.com> writes: > I haven't added test cases here because these intrinsics don't map to > a single instruction (they're legacy from Armv7) and would trip the > "scan-assembler not mov" that we're using for the other tests.
Ah, OK, fair enough. Thanks for the explanation. Richard > > Jonathan > ------------------------------------------------------------------------------- > From: Richard Sandiford <richard.sandif...@arm.com> > Sent: 23 July 2021 10:29 > To: Kyrylo Tkachov <kyrylo.tkac...@arm.com> > Cc: Jonathan Wright <jonathan.wri...@arm.com>; gcc-patches@gcc.gnu.org > <gcc-patches@gcc.gnu.org> > Subject: Re: [PATCH 3/8] aarch64: Use memcpy to copy vector tables in vtbl[34] > intrinsics > > Kyrylo Tkachov <kyrylo.tkac...@arm.com> writes: >>> -----Original Message----- >>> From: Jonathan Wright <jonathan.wri...@arm.com> >>> Sent: 23 July 2021 09:30 >>> To: gcc-patches@gcc.gnu.org >>> Cc: Kyrylo Tkachov <kyrylo.tkac...@arm.com>; Richard Sandiford >>> <richard.sandif...@arm.com> >>> Subject: [PATCH 3/8] aarch64: Use memcpy to copy vector tables in vtbl[34] >>> intrinsics >>> >>> Hi, >>> >>> This patch uses __builtin_memcpy to copy vector structures instead of >>> building a new opaque structure one vector at a time in each of the >>> vtbl[34] Neon intrinsics in arm_neon.h. This simplifies the header file >>> and also improves code generation - superfluous move instructions >>> were emitted for every register extraction/set in this additional >>> structure. >>> >>> Regression tested and bootstrapped on aarch64-none-linux-gnu - no >>> issues. >>> >>> Ok for master? >> >> Ok. > > Please add testcases first though. :-) > > Thanks, > Richard
