RE: [PATCH 2/8] aarch64: Use memcpy to copy vector tables in vqtbx[234] intrinsics

[Kyrylo Tkachov via Gcc-patches]

> -----Original Message-----
> From: Jonathan Wright <jonathan.wri...@arm.com>
> Sent: 23 July 2021 09:27
> To: gcc-patches@gcc.gnu.org
> Cc: Kyrylo Tkachov <kyrylo.tkac...@arm.com>; Richard Sandiford
> <richard.sandif...@arm.com>
> Subject: [PATCH 2/8] aarch64: Use memcpy to copy vector tables in
> vqtbx[234] intrinsics
> 
> Hi,
> 
> This patch uses __builtin_memcpy to copy vector structures instead of
> building a new opaque structure one vector at a time in each of the
> vqtbx[234] Neon intrinsics in arm_neon.h. This simplifies the header
> file and also improves code generation - superfluous move
> instructions were emitted for every register extraction/set in this
> additional structure.
> 
> Add new code generation tests to verify that superfluous move
> instructions are no longer generated for the vqtbx[234] intrinsics.
> 
> Regression tested and bootstrapped on aarch64-none-linux-gnu - no
> issues.
> 
> Ok for master?
> 

Ok.
Thanks,
Kyrill

> Thanks,
> Jonathan
> 
> ---
> 
> gcc/ChangeLog:
> 
> 2021-07-08  Jonathan Wright  <jonathan.wri...@arm.com>
> 
>       * config/aarch64/arm_neon.h (vqtbx2_s8): Use __builtin_memcpy
>       instead of constructing __builtin_aarch64_simd_oi one vector
>       at a time.
>       (vqtbx2_u8): Likewise.
>       (vqtbx2_p8): Likewise.
>       (vqtbx2q_s8): Likewise.
>       (vqtbx2q_u8): Likewise.
>       (vqtbx2q_p8): Likewise.
>       (vqtbx3_s8): Use __builtin_memcpy instead of constructing
>       __builtin_aarch64_simd_ci one vector at a time.
>       (vqtbx3_u8): Likewise.
>       (vqtbx3_p8): Likewise.
>       (vqtbx3q_s8): Likewise.
>       (vqtbx3q_u8): Likewise.
>       (vqtbx3q_p8): Likewise.
>       (vqtbx4_s8): Use __builtin_memcpy instead of constructing
>       __builtin_aarch64_simd_xi one vector at a time.
>       (vqtbx4_u8): Likewise.
>       (vqtbx4_p8): Likewise.
>       (vqtbx4q_s8): Likewise.
>       (vqtbx4q_u8): Likewise.
>       (vqtbx4q_p8): Likewise.
> 
> gcc/testsuite/ChangeLog:
> 
>       * gcc.target/aarch64/vector_structure_intrinsics.c: New tests.