On Mon, 14 Jun 2021 13:36:54 +0100 Julian Brown <jul...@codesourcery.com> wrote:
> On Wed, 9 Jun 2021 16:47:21 +0200 > Marcel Vollweiler <mar...@codesourcery.com> wrote: > > In this patch a compatibility check is added to the configure.ac. > > The implementation of the solution looks fine, but I worry it's the > wrong approach. What would someone packing GCC for a distribution use > for the configuration setting? It'd mean having a dependency on the > exact LLVM version for a given offloading-compiler build -- so LLVM > couldn't be upgraded separately from the offloading compiler. Maybe > that's OK in practice? After discussing this offline, distribution-builders seem to have workarounds for this kind of problems that work fine in practice, and the patch leaves us better off than the status quo (i.e. newer versions of LLVM not working at all). So, I withdraw my objection (but I can't approve the patch). > I wonder if the LLVM assembler has a macro system we could abuse > instead? Perhaps not. (Apparently there's nothing suitable.) Thanks, Julian
