On 14/05/2021 04:36, Prathamesh Kulkarni wrote: > On Wed, 12 May 2021 at 20:33, Richard Earnshaw > <richard.earns...@foss.arm.com> wrote: >> >> On 12/05/2021 12:05, Prathamesh Kulkarni via Gcc-patches wrote: >>> On Wed, 12 May 2021 at 16:02, Richard Earnshaw >>> <richard.earns...@foss.arm.com> wrote: >>>> >>>> >>>> >>>> On 12/05/2021 08:46, Prathamesh Kulkarni via Gcc-patches wrote: >>>>> On Mon, 10 May 2021 at 19:55, Richard Earnshaw >>>>> <richard.earns...@foss.arm.com> wrote: >>>>>> >>>>>> >>>>>> >>>>>> On 06/05/2021 01:14, Prathamesh Kulkarni via Gcc-patches wrote: >>>>>>> Hi, >>>>>>> The attached patch replaces __builtin_neon_vtst* (a, b) with (a & b) != >>>>>>> 0. >>>>>>> Bootstrapped and tested on arm-linux-gnueabihf and cross-tested on >>>>>>> arm*-*-*. >>>>>>> OK to commit ? >>>>>>> >>>>>>> Thanks, >>>>>>> Prathamesh >>>>>>> >>>>>> >>>>>> You're missing the ChangeLog details. >>>>>> >>>>>> Also, if you're removing these, do we still need the neon_vtst<mode> >>>>>> patterns in neon.md? They generate unspecs, so if they're no-longer >>>>>> needed for these expansions, they can likely be dropped entirely. >>>>> Hi Richard, >>>>> Thanks for the suggestions. >>>>> Does the attached patch look OK if bootstrap+test passes ? >>>> >>>> You're still missing the changelog description. >>> Oh, I had attached it separately. >> >> Sorry, I hadn't noticed that. The attachments were in >> application/octet-stream format so don't show up when viewing the >> message - I have to download them and then load them into a separate >> editor or whatever in order to view them. Please don't use octet-stream >> attachments for plain text files. > Oops, sorry about that. >> >> 2021-05-12 Prathamesh Kulkarni <prathamesh.kulka...@linaro.org> >> >> PR target/66791 >> * config/arm/arm_neon.h: Replace calls to __builtin_neon_vtst* (a, >> b) with >> (a & b) != 0. >> >> For a ChangeLog description it's usually better to avoid the exact >> expression. I think it would be better to write. >> >> Replace calls to __builtin_neon_vtst* (a, b) with boolean logic equivalent. >> >> Also, pedantically, you should list every function you've changed (just >> in case somebody searches the ChangeLog for changes that affect, say, >> vtstq_p8). There aren't that many affected functions in this specific >> patch that that is an unreasonable thing to do >> >> * config/arm/arm_neon_builtins.def: Remove entry for vtst. >> * config/arm/neon.md (neon_vtst<mode>): Remove pattern. >> >> OK with those changes. > Is the attached version OK to commit ? > Bootstrapped + tested on arm-linux-gnueabihf and cross-tested on arm*-*-*.
OK. R. > > Thanks, > Prathamesh >> >> R. >> >>> Does this version look OK ? >>> >>> Thanks, >>> Prathamesh >>>> >>>> R. >>>>> >>>>> Thanks, >>>>> Prathamesh >>>>>> >>>>>> R. >>
