On April 28, 2021 6:37:56 PM GMT+02:00, Jeff Law <jeffreya...@gmail.com> wrote: > >On 4/28/2021 1:59 AM, Richard Biener wrote: >> This makes sure to fall into the >delete_unreachable_blocks_update_callgraph >> handling to remove blocks becoming unreachable when removing EH edges >> by tracking blocks to need EH cleanup and doing that after releasing >> dominance info. >> >> This fixes an ICE seen with gfortran.dg/gomp/pr88933.f90 when >enhancing >> DSE. >> >> 2021-04-28 Richard Biener <rguent...@suse.de> >> >> PR ipa/100308 >> * ipa-prop.c (ipcp_modif_dom_walker::before_dom_children): >> Track blocks to cleanup EH in new m_need_eh_cleanup. >> (ipcp_modif_dom_walker::cleanup_eh): New. >> (ipcp_transform_function): Release dominator info before >> doing EH cleanup. > >OK. Though I'd really like us to revisit some of Aldy's work which was > >meant to have a standardized way to do this which was automatic rather >than have each pass roll its own, slightly different, ways to clean up >dead EH edges.
Not sure what to factor out here though apart from putting some of the tracking bits into the DOM walker. In this case you'd need to make sure to update the callgraph properly as well... Richard. > >Jeff
