On Mon, Apr 19, 2021 at 11:26:04AM +0200, Richard Biener wrote:
> This reverts a s/column_offset/column/ change in the fix for PR99446.
>
> This time with testcase included in the patch and the necessary reversion
> of the testsuite change of the offending rev.
>
> Bootstrapped and tested on x86_64-unknown-linux-gnu, OK?
>
> Thanks,
> Richard.
>
> 2021-04-19 Richard Biener <[email protected]>
>
> PR preprocessor/100142
> libcpp/
> * line-map.c (linemap_position_for_loc_and_offset): Revert
> unintended s/column_offset/column/ change.
>
> * gcc.dg/pr100142.c: New testcase.
> * g++.dg/diagnostic/pr72803.C: Revert last change.
LGTM, but please give Nathan 2-3 hours to chime in if the change was
intentional.
Jakub