On Mar 24, 2021, Uros Bizjak <ubiz...@gmail.com> wrote: > On Mar 24, 2021, Uros Bizjak <ubiz...@gmail.com> wrote:
>> There are several other tests in gcc.target/i386 directory that call sysconf: Ooh, indeed, thanks, good catch. The reason I didn't catch them was that the full test results analysis that got me started at it was in a gcc-10 branch, that doesn't have those other tests. In the trunk, I only ran regression testing for the patch, so I didn't notice that there were other fails, before and after, for the same reasons. > Other than above, can you please introduce > check_effectve_target_sysconf to lib/target-supports.exp (similar to > existing check_effective_target_mmap) and use it instead of target > selectors? I'll take care of that, and of the fails I'd missed. Thanks! > The testsuite is moving away from target checks to feature tests, so > bonus points if you also convert existing testcases to a new feature > test. *nod* -- Alexandre Oliva, happy hacker https://FSFLA.org/blogs/lxo/ Free Software Activist GNU Toolchain Engineer Vim, Vi, Voltei pro Emacs -- GNUlius Caesar
