On Fri, Feb 26, 2021 at 11:09 AM Alexandre Oliva <ol...@adacore.com> wrote:
>
> This patch avoids an ICE in gimplefe-28.c, in our ppc64-vxworks7r2
> tests.  Tested on x86_64-linux-gnu, and on the affected platform.  Ok to
> install?

I'm sort of surprised that sqrt instruction would be available for the
target but not enabled by default.  Is this really the method that
customers would use?  It seems that it might be more appropriate to
xfail or skip the test for PPC64 VxWorks.

Thanks, David

>
>
> From: Eric Botcazou <ebotca...@adacore.com>
> for  gcc/testsuite/ChangeLog
>
>         * lib/target-supports.exp (add_options_for_sqrt_insn): For
>         PowerPC targets, add -mpowerpc-gpopt option.
> ---
>  gcc/testsuite/lib/target-supports.exp |    3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/gcc/testsuite/lib/target-supports.exp 
> b/gcc/testsuite/lib/target-supports.exp
> index af46c77921482..29faeeba67945 100644
> --- a/gcc/testsuite/lib/target-supports.exp
> +++ b/gcc/testsuite/lib/target-supports.exp
> @@ -7598,6 +7598,9 @@ proc add_options_for_sqrt_insn { flags } {
>      if { [istarget arm*-*-*] } {
>         return [add_options_for_arm_vfp "$flags"]
>      }
> +    if { [istarget powerpc*-*-*] } {
> +       return "$flags -mpowerpc-gpopt"
> +    }
>      return $flags
>  }
>
>
>
> --
> Alexandre Oliva, happy hacker  https://FSFLA.org/blogs/lxo/
>    Free Software Activist         GNU Toolchain Engineer
>         Vim, Vi, Voltei pro Emacs -- GNUlius Caesar

Reply via email to