Janne Blomqvist wrote:
Have you tried r183679, which should fix this?
Aha, I missed the follow up patch - that explains why I didn't see it.
While I can speak only for myself, regtesting on x86_64-unknown-linux-gnu. For some reason this was/is flagged as a warning for me, not an error, so I missed it among all the other warnings. Perhaps something to do with me using --disable-bootstrap,
Yes. I think the logic of having no -Werror with --disable-bootstrap is the following: The compiler is the system compiler and it might have different - and completely bogus - warnings. Thus, as the basis (the system compiler) is not known, it is better to not stop the build with an error. While for bootstrapping, one knows that Stage 2 and Stage 3 are the current GCC. Thus, the compiler is well defined and thus compiling with -Werror is possible without causing any breakage.
Thus: Better to do a full bootstrap - or at least watch for warnings. (Side note: The libgfortran library does not use -Werror. Thus, one should occasionally manually check for warnings.)
Tobias
