Thanks Jim, committed with your revision of comment :)
On Fri, Feb 5, 2021 at 11:28 AM Jim Wilson <j...@sifive.com> wrote: > > On Thu, Feb 4, 2021 at 2:02 AM Kito Cheng <kito.ch...@sifive.com> wrote: >> >> * gcc.c (print_multilib_info): Check all required argument is >> provided >> by default arg. > > > This looks OK to me, but... >> >> >> - /* If this directory requires any default arguments, we can skip >> + /* If this directory requires any default arguments, and any default >> + arguments not appear in the ! argument list, then we can skip >> it. We will already have printed a directory identical to >> this one which does not require that default argument. */ > > > I would suggest "any default arguments not appear in the ! argument list" to > be instead "no default arguments appear in the ! argument list". But there > are actually 3 conditions being tested, and the comment only mentions 2. The > other condition is that a required argument must appear in the default > argument list. That can be combined with the first condition by saying all > required arguments must be default arguments. So maybe something like > > /* If all required arguments are default arguments, and no default > arguments appear in the ! argument list, then we can skip it. > > Jim >
