On 1/21/21 5:45 PM, Marek Polacek wrote:
I discovered very strange code in inject_parm_decls:if (args && is_this_parameter (args)) { gcc_checking_assert (current_class_ptr == NULL_TREE); current_class_ptr = NULL_TREE; We are tripping up on the assert because when we call inject_parm_decls, current_class_ptr is set to 'A'. It was set by inject_this_parameter after we've parsed the parameter-declaration-clause of the member function foo.
But then it should be restored (to null) by the ccp = save_ccp a few lines later.
It seems correct to set ccp/ccr to A::B when we're late parsing the noexcept-specifiers of bar* functions in B, so that this-> does the right thing.
Agreed.
Since inject_parm_decls can mess with ccp/ccr, I think best if we properly restore it after the late parsing of noexcept-specifiers.
pop_injected_parms clears them, which is restoring them if we keep the assert.
It should also work to clear ccp before calling inject_parm_decls, and removing the assignment following the assert, should the assert stay.
But why is it non-null before parsing the unparsed_noexcepts? Jason
