> The patch is about not using delete for a memory that
> is allocated by GGC.
> 
> Patch can bootstrap on x86_64-linux-gnu and survives regression tests.
> 
> Ready to be installed?
> Thanks,
> Martin
> 
> gcc/ChangeLog:
> 
>       PR jit/98615
>       * symtab-clones.h (clone_info::release): Release
>       symtab::m_clones with ggc_delete as it's a GGC memory.

OK, so this does not cause regular crashes because it is run only with
JIT? Sorry for that.

I was thinking of making the finalizers to be run also with checking
enabled - that should catch such errors soner.

Honza
> ---
>  gcc/symtab-clones.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gcc/symtab-clones.h b/gcc/symtab-clones.h
> index cdb19cb6c8c..5695a434f6a 100644
> --- a/gcc/symtab-clones.h
> +++ b/gcc/symtab-clones.h
> @@ -83,7 +83,7 @@ inline void
>  clone_info::release ()
>  {
>    if (symtab->m_clones)
> -    delete (symtab->m_clones);
> +    ggc_delete (symtab->m_clones);
>    symtab->m_clones = NULL;
>  }
> -- 
> 2.29.2
> 

Reply via email to