On Tue, 22 Dec 2020 at 12:01, Martin Liška <mli...@suse.cz> wrote:
>
> On 12/22/20 12:46 PM, Jonathan Wakely wrote:
> > On Tue, 22 Dec 2020 at 08:29, Martin Liška <mli...@suse.cz> wrote:
> >>
> >> Hello.
> >>
> >> May I please ask a native speaker for a correction of my wording?
> >>
> >> Thanks,
> >> Martin
> >>
> >> ---
> >>    htdocs/gcc-11/changes.html | 28 ++++++++++++++++++++++++++++
> >>    1 file changed, 28 insertions(+)
> >>
> >> diff --git a/htdocs/gcc-11/changes.html b/htdocs/gcc-11/changes.html
> >> index 1a9e72c1..badc9e12 100644
> >> --- a/htdocs/gcc-11/changes.html
> >> +++ b/htdocs/gcc-11/changes.html
> >> @@ -116,6 +116,28 @@ a work-in-progress.</p>
> >>          option (which defaults to 8 spaces per tab stop).
> >>        </p>
> >>      </li>
> >> +  <li>New warning <a 
> >> href="https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wtsan";><code>-Wtsan</code></a>,
> >>  enabled by default,
> >
> > "A new warning" or "The new warning". My preference would be "a new 
> > warning".
> >
> >> +      warns about unsupported features in ThreadSanitizer 
> >> (<code>std::atomic_thread_fence</code>).</li>
> >> +  <li>Series of if conditions, sharing a common index variable, can be 
> >> transformed into a switch statement if each
> >
> > There is no "if" condition in your example, and I don't know what the
> > "index variable" is either.
> >
> > "A series of conditional expressions that compare the same variable
> > can be transformed into a switch statement" seems to be what you want
> > to say.
>
> I like the wording.
>
> >
> >> +      of them contains a comparison expession.  Example:
> >> +      <pre>
> >> +        int IsHTMLWhitespace(int aChar) {
> >> +          return aChar == 0x0009 || aChar == 0x000A ||
> >> +                 aChar == 0x000C || aChar == 0x000D ||
> >> +                 aChar == 0x0020;
> >> +        }
> >> +       </pre>
> >> +       The statement is transformed into a GIMPLE switch statement that 
> >> is later effectively expanded as bit-test.
> >
> > Do users know or care about GIMPLE? I'm unsure what "effectively
> > expanded as bit-test" means.
>
> They don't care. I wanted to express that such transformation can lead in a 
> faster
> code eventually. Do you have a suggesting for wording?

Maybe "This statement can be transformed into a switch statement and
then expanded into a bit-test." ?

>
> >
> >
> >> +  </li>
> >> +  <li>
> >> +    New command-line options:
> >> +    <ul>
> >> +        <li><a 
> >> href="https://gcc.gnu.org/onlinedocs/gcc/Code-Gen-Options.html#index-fno-bit-tests";><code>-fbit-tests</code></a>,
> >>  enabled by default, can be used to enable or disable switch expansion 
> >> using bit-tests.</li>
> >> +    </ul>
> >> +  </li>
> >> +  <li>GCOV data file format can effectively store a group of counters 
> >> that are all zero.</li>
> >
> > What does "effectively" mean here? It can have two slightly different
> > meanings in English, it can mean "doing a good job" or "not
> > officially, but in practice".
>
> It means doing a good job :)
> What about: "The GCOV data file format outputs smaller files as zero counters 
> can be represented in a compact way." ?

That seems good to me, but I think this reads a little better: "The
GCOV data file format outputs smaller files by representing zero
counters in a more compact way." ",

Or use Martin J's suggestion: "The GCOV data file format can more
efficiently store a group of counters that are all zero."

Reply via email to