On 12/15/20 10:30 AM, H.J. Lu wrote:
> Since SHF_GNU_RETAIN support doesn't work for crtstuff.c which switches
> the output section directly with asm statement:
>
> ---
> static void __attribute__((used))
> __do_global_dtors_aux (void)
> {
> static _Bool completed;
>
> if (__builtin_expect (completed, 0))
> return;
> completed = 1;
> }
>
> static void __attribute__((__used__))
> call___do_global_dtors_aux (void)
> {
> asm ("\t.section\t.fini");
> __do_global_dtors_aux ();
> asm ("\t.section\t.text");
> }
> ---
>
> use SHF_GNU_RETAIN only if .init_array/.fini_array section is supported.
>
> gcc/
>
> PR target/98146
> * defaults.h (SUPPORTS_SHF_GNU_RETAIN): New.
> * varasm.c (get_section): Replace HAVE_GAS_SHF_GNU_RETAIN with
> SUPPORTS_SHF_GNU_RETAIN.
> (resolve_unique_section): Likewise.
> (get_variable_section): Likewise.
> (switch_to_section): Likewise.
>
> gcc/testsuite/
>
> PR target/98146
> * lib/target-supports.exp
> (check_effective_target_R_flag_in_section): Also check
> HAVE_INITFINI_ARRAY_SUPPORT != 0.
Ah. I didn't realize that you added this to the V4 patch. OK.
jeff
