On Tue, Dec 15, 2020 at 12:48:47AM +0100, Gerald Pfeifer wrote:
> On Mon, 7 Dec 2020, Jozef Lawrynowicz wrote:
> > Committed as obvious.
> 
> Thank you!
> 
> +  <li>
> +    For ELF targets that support the GNU or FreeBSD OSABIs, the
> +    <code>used</code> attribute will now save the symbol declaration it is
> +    applied to from linker garbage collection.
> +    <br>
> +    To support this behavior, <code>used</code> symbols that have not
> +    been placed in specific sections (e.g. with the <code>section</code>
> +    attribute, or the <code>-f{function,data}-sections</code> options) will
> +    be placed in new, unique sections.
> +    <br>
> +    This functionality requires Binutils version 2.36 or later.
> +  </li>
> 
> Have you considered using <p>...</p> around the three blocks of
> text instead of <br> in between?
> 
> An open question, it's okay to keep as is if you prefer.

I did try with <p>...</p>, but I thought the additional line spacing
just looked a little out of place amongst all the other lines in this
section, which are list items so have compact line spacing. However,
since they are separate paragraphs there should be some formatting to
show this.

Also, I guess that using <br> to override the house style in this way is
a bit of a no-no, so I will change it to <p>...</p>.

Committed the attached patch.

Thanks,
Jozef
>From fb048b7d45422cd869772462cba591a46f1b3b2f Mon Sep 17 00:00:00 2001
From: Jozef Lawrynowicz <joze...@mittosystems.com>
Date: Tue, 15 Dec 2020 11:19:41 +0000
Subject: [PATCH] gcc-11/changes: Use <p> instead of <br> for "used" attribute
 description

---
 htdocs/gcc-11/changes.html | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/htdocs/gcc-11/changes.html b/htdocs/gcc-11/changes.html
index ea9fe93c..1a9e72c1 100644
--- a/htdocs/gcc-11/changes.html
+++ b/htdocs/gcc-11/changes.html
@@ -159,16 +159,20 @@ a work-in-progress.</p>
     </ul>
   </li>
   <li>
+    <p>
     For ELF targets that support the GNU or FreeBSD OSABIs, the
     <code>used</code> attribute will now save the symbol declaration it is
     applied to from linker garbage collection.
-    <br>
+    </p>
+    <p>
     To support this behavior, <code>used</code> symbols that have not
     been placed in specific sections (e.g. with the <code>section</code>
     attribute, or the <code>-f{function,data}-sections</code> options) will
     be placed in new, unique sections.
-    <br>
+    </p>
+    <p>
     This functionality requires Binutils version 2.36 or later.
+    </p>
   </li>
 </ul>
 
-- 
2.29.2

Reply via email to