On Thu, 2020-12-10 at 11:21 -0500, Patrick Palka via Gcc-patches wrote:
> + if (entry->diagnose_instability)
> + {
> + error_at (EXPR_LOCATION (ATOMIC_CONSTR_EXPR (entry->atom)),
> + "satisfaction value of atomic constraint %qE changed "
> + "from %qE to %qE", entry->atom, entry->result,
> result);
> + inform (entry->location,
> + "satisfaction value first evaluated to %qE from here",
> + entry->result);
> + }
I only glanced at the rest of the patch, but a minor nit I spotted
here: please add an
auto_diagnostic_group d;
to this block to associate the "note" with the "error".
Dave
