On Thu, Oct 29, 2020 at 10:10:58PM +1030, Alan Modra wrote: > Fixes > FAIL: gcc.target/powerpc/signbit-1.c scan-assembler-not stxvd2x > FAIL: gcc.target/powerpc/signbit-1.c scan-assembler-times mfvsrd 3 > FAIL: gcc.target/powerpc/signbit-1.c scan-assembler-times srdi 3 > FAIL: gcc.target/powerpc/signbit-2.c scan-assembler-times ld 1 > FAIL: gcc.target/powerpc/signbit-2.c scan-assembler-times srdi 1 > on powerpc-linux (or powerpc64-linux biarch -m32).
David, This patch is fixing a regression caused by one of your testsuite patches. Please review. https://gcc.gnu.org/pipermail/gcc-patches/2020-October/557443.html > signbit-1.c is quite obviously a 64-bit only testcase given the > scan-assembler directives, and the purpose of the testcase to verify > the 64-bit only UNSPEC_SIGNBIT patterns. It could be made to pass for > -m32 by adding -mpowerpc64, but that option that isn't very effective > when bi-arch testing and results in errors on rs6000-aix. And it is > pointless to match -m32 stores to the stack followed by loads, which > is what we do at the moment. > > signbit-2.c on the other hand has more reasonable 32-bit output. > > Regression tested powerpc64-linux biarch. > > * gcc.target/powerpc/signbit-1.c: Reinstate lp64 condition. > * gcc.target/powerpc/signbit-2.c: Match 32-bit output too. > > diff --git a/gcc/testsuite/gcc.target/powerpc/signbit-1.c > b/gcc/testsuite/gcc.target/powerpc/signbit-1.c > index eb4f53e397d..1642bf46d7a 100644 > --- a/gcc/testsuite/gcc.target/powerpc/signbit-1.c > +++ b/gcc/testsuite/gcc.target/powerpc/signbit-1.c > @@ -1,4 +1,5 @@ > /* { dg-do compile } */ > +/* { dg-require-effective-target lp64 } */ > /* { dg-require-effective-target ppc_float128_sw } */ > /* { dg-require-effective-target powerpc_p8vector_ok } */ > /* { dg-options "-mdejagnu-cpu=power8 -O2 -mfloat128" } */ > diff --git a/gcc/testsuite/gcc.target/powerpc/signbit-2.c > b/gcc/testsuite/gcc.target/powerpc/signbit-2.c > index ff6af963dda..1b792916eba 100644 > --- a/gcc/testsuite/gcc.target/powerpc/signbit-2.c > +++ b/gcc/testsuite/gcc.target/powerpc/signbit-2.c > @@ -13,5 +13,7 @@ int do_signbit_kf (__float128 *a) { return > __builtin_signbit (*a); } > /* { dg-final { scan-assembler-not "lxvw4x" } } */ > /* { dg-final { scan-assembler-not "lxsd" } } */ > /* { dg-final { scan-assembler-not "lxsdx" } } */ > -/* { dg-final { scan-assembler-times "ld" 1 } } */ > -/* { dg-final { scan-assembler-times "srdi" 1 } } */ > +/* { dg-final { scan-assembler-times "ld" 1 { target lp64 } } } */ > +/* { dg-final { scan-assembler-times "srdi" 1 { target lp64 } } } */ > +/* { dg-final { scan-assembler-times "lwz" 1 { target ilp32 } } } */ > +/* { dg-final { scan-assembler-times "rlwinm" 1 { target ilp32 } } } */ -- Alan Modra Australia Development Lab, IBM
