Re: [PATCH] [X86] Delete Deadcode.

[Hongtao Liu via Gcc-patches]

On Thu, Nov 26, 2020 at 4:11 PM Uros Bizjak <ubiz...@gmail.com> wrote:
>
> > Hi:
> >  This patch is about to delete dead code in 
> > ix86_expand_special_args_builtin.
> >
> >   Bootstrap and regression test are ok.
> >
> > gcc/ChangeLog:
> >         * config/i386/i386-expand.c
> >         (ix86_expand_special_args_builtin): Delete last_arg_constant.
>
> @@ -10824,48 +10823,37 @@ ix86_expand_special_args_builtin (const
> struct builtin_description *d,
>        op = expand_normal (arg);
>        match = insn_p->operand[i + 1].predicate (op, mode);
>
> -      if (last_arg_constant && (i + 1) == nargs)
> +      if (i == memory)
>
> Please also remove unused variable "match".
>
> OK with the above addition.
>
> Thanks,
> Uros.

Yes, will run another round regression test and bootstrap, just to be
on the safe side

@@ -10818,54 +10817,41 @@ ix86_expand_special_args_builtin (const
struct builtin_description *d,
   for (i = 0; i < nargs; i++)
     {
       machine_mode mode = insn_p->operand[i + 1].mode;
-      bool match;

       arg = CALL_EXPR_ARG (exp, i + arg_adjust);
       op = expand_normal (arg);
-      match = insn_p->operand[i + 1].predicate (op, mode);

-- 
BR,
Hongtao