On 11/24/20 8:53 AM, Martin Sebor wrote:
On 11/23/20 9:31 PM, Jeff Law wrote:
On 11/20/20 4:14 PM, Jeff Law wrote:
On 11/20/20 11:12 AM, Martin Sebor via Gcc-patches wrote:
dump_function_to_file prints DECL_ATTRIBUTES but not TYPE_ATTRIBUTES
when both can be important and helpful for debugging, especially with
attributes that are added implicitly (such attribute access and
the proposed internal attribute *dealloc). The function also prints
function arguments (and their types) but not its return type, again,
leaving out a useful detail. The attached tweak adds both to
the dump.
Martin
gcc-dump-type-attr.diff
gcc/ChangeLog:
* gcc/tree-cfg.c (dump_function_to_file): Print type attributes
and return type.
gcc/testsuite/ChangeLog:
* gcc.dg/attr-access-4.c: New test.
So was this actually regression tested? Even tests that change dump
files need to be regression tested because some of the tests scan those
dump files.
I'm seeing this on several targets:
Tests that now fail, but worked before (6 tests):
xstormy16-sim: gcc.dg/tree-ssa/pr23401.c scan-tree-dump-times gimple
"int" 5
xstormy16-sim: gcc.dg/tree-ssa/pr23401.c scan-tree-dump-times gimple
"int" 5
xstormy16-sim: gcc.dg/tree-ssa/pr27810.c scan-tree-dump-times gimple
"int" 3
xstormy16-sim: gcc.dg/tree-ssa/pr27810.c scan-tree-dump-times gimple
"int" 3
xstormy16-sim: gcc.dg/tree-ssa/slsr-8.c scan-tree-dump-times optimized
" w?\\* " 9
xstormy16-sim: gcc.dg/tree-ssa/slsr-8.c scan-tree-dump-times optimized
" w?\\* " 9
From my quick reading, these tests are likely failing across the board.
It was tested with the results below. I looked onto the jit
failures (test-combination.c.exe etc.) but overlooked those
in the tree-ssa directory because of all the perpetual guality
clutter.
I committed r11-5321 to fix up the gfortran.dg/gomp/declare-target-4.f90
regex pattern. Thank you for cleaning up the others.
! FAIL: gcc.dg/atomic/pr65345-4.c (4: +4)ESC[0m
! FAIL: gcc.dg/guality/loop-1.c (1: +1)ESC[0m
! FAIL: gcc.dg/guality/pr36728-2.c (28: +28)ESC[0m
! FAIL: gcc.dg/guality/pr36728-4.c (4: +4)ESC[0m
! FAIL: gcc.dg/guality/pr41616-1.c (3: +3)ESC[0m
! FAIL: gcc.dg/guality/pr54519-1.c (8: +8)ESC[0m
! FAIL: gcc.dg/guality/pr54519-2.c (2: +2)ESC[0m
! FAIL: gcc.dg/guality/pr54519-3.c (8: +8)ESC[0m
! FAIL: gcc.dg/guality/pr54519-4.c (2: +2)ESC[0m
! FAIL: gcc.dg/guality/pr54519-5.c (2: +2)ESC[0m
! FAIL: gcc.dg/guality/pr54519-6.c (1: +1)ESC[0m
! FAIL: gcc.dg/guality/pr56154-1.c (1: +1)ESC[0m
! FAIL: gcc.dg/guality/pr59776.c (6: +6)ESC[0m
! FAIL: gcc.dg/guality/pr90074.c (2: +2)ESC[0m
! FAIL: gcc.dg/guality/pr90716.c (1: +1)ESC[0m
! FAIL: gcc.dg/guality/sra-1.c (16: +16)ESC[0m
! FAIL: gcc.dg/guality/vla-1.c (8: +8)ESC[0m
! FAIL: gcc.dg/tree-ssa/pr23401.c (1: +1)ESC[0m
! FAIL: gcc.dg/tree-ssa/pr27810.c (1: +1)ESC[0m
! FAIL: gcc.dg/tree-ssa/slsr-8.c (1: +1)ESC[0m
! FAIL: gdc.dg/intrinsics.d (3: +3)ESC[0m
! FAIL: g++.dg/guality/pr55665.C (1: +1)ESC[0m
! FAIL: gfortran.dg/gomp/declare-target-4.f90 (8: +8)ESC[0m
! FAIL: test-combination.c.exe (1: +1)ESC[0m
! FAIL: test-functions.c.exe (1: +1)ESC[0m
! FAIL: test-pr66779.c.exe (1: +1)ESC[0m
! FAIL: test-threads.c.exe (1: +1)ESC[0m
! XPASS: gcc.dg/analyzer/pr94851-1.c (1: +1)ESC[0m
! XPASS: gcc.dg/guality/example.c (3: +3)ESC[0m
! XPASS: gcc.dg/guality/guality.c (8: +8)ESC[0m
! XPASS: gcc.dg/guality/inline-params.c (5: +5)ESC[0m
! XPASS: gcc.dg/guality/pr41353-1.c (2: +2)ESC[0m
! XPASS: gcc.dg/guality/pr54970.c (16: +16)ESC[0m
! XPASS: gcc.dg/guality/pr59776.c (2: +2)ESC[0m
jeff
