On 24/11/2020 12:30, Hongtao Liu wrote:
Hi:
I'm learning about this patch, and I see one place that might be
slighted improved.
+ poly_int64 size = (top - bot);
+
+ /* Assert the edge of each variable is aligned to the HWASAN tag granule
+ size. */
+ gcc_assert (multiple_p (top, HWASAN_TAG_GRANULE_SIZE));
+ gcc_assert (multiple_p (bot, HWASAN_TAG_GRANULE_SIZE));
+ gcc_assert (multiple_p (size, HWASAN_TAG_GRANULE_SIZE));
+
The last gcc_assert looks redundant?
Hi
I think you're right.
Just FYI I'm planning on making that change as an obvious fix after the
patchset as it is now goes in.
That way I can say I ran all my tests on the patch series that I applied
without going through the all the tests again.
Thanks for the catch!
Matthew
On Sat, Nov 21, 2020 at 2:48 AM Matthew Malcomson via Gcc-patches
<gcc-patches@gcc.gnu.org> wrote:
