Change the default that is used by GIT server hook and also
by git_update_version.py. Both should use True now.

Right now the server hook uses:
home/gccadmin/hooks-bin/commit_checker

        commits = parse_git_revisions(os.environ['GIT_DIR'], commit_rev)
        errs = []
        for commit in commits:
            if not commit.success:
                errs.extend(commit.errors)
        if errs:
            message = 'ChangeLog format failed:\n'
            for err in errs:
                message += 'ERR: %s\n' % err
            message += '\nPlease see: 
https://gcc.gnu.org/codingconventions.html#ChangeLogs\n'
            error(message)

which means it now uses non-strict mode. That's bad.

Martin

contrib/ChangeLog:

        * gcc-changelog/git_repository.py: Set strict=True
        for parse_git_revisions as a default.
---
 contrib/gcc-changelog/git_repository.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/gcc-changelog/git_repository.py 
b/contrib/gcc-changelog/git_repository.py
index 90edc3ce3d8..8edcff91ad6 100755
--- a/contrib/gcc-changelog/git_repository.py
+++ b/contrib/gcc-changelog/git_repository.py
@@ -29,7 +29,7 @@ except ImportError:
 from git_commit import GitCommit, GitInfo
-def parse_git_revisions(repo_path, revisions, strict=False):
+def parse_git_revisions(repo_path, revisions, strict=True):
     repo = Repo(repo_path)
def commit_to_info(commit):
--
2.29.1

Reply via email to